Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #411

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Sep 18, 2023

This should squash all the mutants which are detected in #388

@Ocramius Ocramius added this to the 4.7.0 milestone Sep 18, 2023
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides CS issues, nice!

test/fixtures/validJsonExcessiveDepth.json Show resolved Hide resolved
@Ocramius Ocramius mentioned this pull request Sep 18, 2023
@fredden fredden force-pushed the infection/kill-all-mutants branch from 5f88b9d to 055724e Compare September 18, 2023 11:26
@fredden
Copy link
Contributor Author

fredden commented Sep 18, 2023

Besides CS issues

Sorry! I forgot to run the full test-suite before pushing up / committing. I was too focused on just the mutation stuff it seems. I've force-pushed with the fixes applied by phpcbf.

@Ocramius
Copy link
Collaborator

Thanks @fredden!

@Ocramius Ocramius self-assigned this Sep 18, 2023
@Ocramius Ocramius merged commit a4847a4 into maglnet:4.7.x Sep 18, 2023
17 checks passed
@fredden fredden deleted the infection/kill-all-mutants branch September 18, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants