Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with some URLs #47

Open
mohamedsamara opened this issue Dec 10, 2021 · 6 comments
Open

Issue with some URLs #47

mohamedsamara opened this issue Dec 10, 2021 · 6 comments

Comments

@mohamedsamara
Copy link

Description
REGEX match returns null for this url example.

URL Example: https://lightning.engineering/posts/2021-11-30-lightning-terminal

[Screenshot]

Simulator Screen Shot - iPhone 12 - 2021-12-10 at 13 31 21

@JoelKronander
Copy link

+1

@lieberscott
Copy link

There is no error when I use the url you provided, it works as intended

@Mihai-github
Copy link

@mohamedsamara I can confirm with your link I also don't have any issue but with this one that I am currently having and trying to debug it on Android since on iOS the app is not crashing as Android does:

The link with problems: https://donate.giveasyoulive.com/donate?eid=19178

@fukemy
Copy link

fukemy commented Nov 19, 2022

hi @Mihai-github , I confirm your link cause crash app iwith Android, did u found any solution?

@Mihai-github
Copy link

hi @Mihai-github , I confirm your link cause crash app iwith Android, did u found any solution?

Hi, uhh a bit long time passed since that issue :)) .
I could not find a reason why the link had issue. Every test I did worked but something was wrong with that link...

We had to removed it from production manually and hope we don't have any more issues with links like this..

But what I think is something breakes with the native system trying to make the requst to get the metadata of that site but could not find what exactly 🤔 the operating system did no like about it 😅

If someone would find out maybe will leave us the answer to know for future issue... would help many I guess 😁

@fukemy
Copy link

fukemy commented Nov 21, 2022

i sure some props is null for this case, so it's make app crash. So I think we need add '?' for ensure avoid crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants