Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register API: Missing a way to get all nodes from Merkle Register CRDT #858

Open
b-zee opened this issue Dec 16, 2021 · 2 comments
Open
Assignees

Comments

@b-zee
Copy link
Contributor

b-zee commented Dec 16, 2021

I might be missing something, but it seems like there is no way to retrieve the low-level crdts::merkle_reg::MerkleReg.

There is a safe_network::client::Client::get_register function that returns a Register type, but this can only be used to query specific entries with a known hash, or the root entries.

(As an aside, I think the term 'entry' is a little confusing in the context of DAGs.)

@joshuef
Copy link
Contributor

joshuef commented May 3, 2022

@b-zee what are you after with accessing the MerkleReg?

Probably we need to expose an API for traversal (and keep the underlying data structs hidden).

@b-zee
Copy link
Contributor Author

b-zee commented May 3, 2022

In short, I believed it would provide developers with the opportunity to use the node graph as a public append-only structure. E.g. a chat where each node in the graph is a message. For such algorithms, I thought it necessary to access the whole graph of nodes.

I'm not sure I see what such a traversal API would look like. The graph can be quite complex and is exactly what is modeled by the data structure itself...

@b-zee b-zee self-assigned this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants