Skip to content

Commit

Permalink
Merge pull request #400 from mailgun/increase-minimal-supported-node-…
Browse files Browse the repository at this point in the history
…version

breaking: Update minimally supported version of Node.js
  • Loading branch information
olexandr-mazepa authored Jan 18, 2024
2 parents d557d9c + f89bbf1 commit c2f73b1
Show file tree
Hide file tree
Showing 8 changed files with 24,383 additions and 70 deletions.
76 changes: 52 additions & 24 deletions .github/workflows/on-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,34 +11,62 @@ on:
- main

jobs:
on-pull-request:
name: test
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
runs-on: 'ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3
lint:
name: lint
runs-on: 'ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3

- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- uses: actions/setup-node@v3
with:
node-version: "18.x"

- name: Print node version
run: node -v
- name: Install dependencies
run: npm ci

- name: Install dependencies
run: npm ci
- name: Run linter
run: npm run lint
test:
name: Test
strategy:
matrix:
node-version: [18.x, 20.x]
runs-on: 'ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Run linter
run: npm run lint
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Run build
run: npm run build
- name: Print node version
run: node -v

- name: Run tests
run: npm test
- name: Install dependencies
run: npm ci

- name: Show expected changes in the changelog file
run: npm run release:test
- name: Run build
run: npm run build

- name: Run tests
run: npm test

- name: Show expected changes in the changelog file
run: npm run release:test
changelog:
name: Changelog check
runs-on: 'ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "18.x"
- name: Print node version
run: node -v
- name: Install dependencies
run: npm ci
- name: Show expected changes in the changelog file
run: npm run release:test
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ __Table of Contents__

## Install

- Requires node.js >= 12.x
- Requires node.js >= 18.x

Install mailgun.js with:

Expand Down Expand Up @@ -2414,4 +2414,3 @@ git pull
Next, run ```npm run release```.

After that, `cd ./dist` and then run ```npm login``` and ```npm publish``` to publish changes on npm.

3 changes: 1 addition & 2 deletions dist/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ __Table of Contents__

## Install

- Requires node.js >= 12.x
- Requires node.js >= 18.x

Install mailgun.js with:

Expand Down Expand Up @@ -2414,4 +2414,3 @@ git pull
Next, run ```npm run release```.

After that, `cd ./dist` and then run ```npm login``` and ```npm publish``` to publish changes on npm.

14,484 changes: 14,481 additions & 3 deletions dist/mailgun.node.js

Large diffs are not rendered by default.

9,806 changes: 9,803 additions & 3 deletions dist/mailgun.web.js

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions dist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
"base-64": "^1.0.0",
"url-join": "^4.0.1"
},
"engines": {
"node": ">=18.0.0"
},
"contributors": [
{
"name": "Brad Gignac",
Expand Down
75 changes: 39 additions & 36 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@
"webpack-cli": "^4.1.0",
"webpack-merge": "^5.8.0"
},
"engines" : {
"node" : ">=18.0.0"
},
"contributors": [
{
"name": "Brad Gignac",
Expand Down

0 comments on commit c2f73b1

Please sign in to comment.