Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to this module #12

Open
PierreMesure opened this issue Jan 4, 2021 · 2 comments
Open

Contributing to this module #12

PierreMesure opened this issue Jan 4, 2021 · 2 comments

Comments

@PierreMesure
Copy link
Contributor

Hi Antti,

Happy new year! I wish you a 2021 full of love and happiness and hope we can see each other as soon as the Decidim community can meet physically again (maybe in Helsinki)!

I'm starting to test this module more heavily in early 2021 with a goal of using it on our Swedish platforms.

I'm gonna push bug fixes your way as I test the module in our own context and with a different infrastructure (especially regarding map providers where I'm still trying out different setups).
I'm also gonna send you some cosmetic fixes for the default Decidim layout, as some HTML elements were forgotten when you designed the module views (probably with Omastadi's theme in mind).

None of these fixes should negatively impact the way the module is used in Omastadi so I don't think I need to confirm them with you too much in advance.

In addition to that, I'm also wondering if you'd be open to changes in the views and the controllers as these might impact more on the module's design and inner working. In this case, I'd make a proposal as an issue and get your approval on it before starting any work to avoid wasting time. This one is a first example.

@ahukkanen
Copy link
Collaborator

Hi Pierre,

Great to see you are putting effort into this. I'll just answer briefly:

  • Bugfixes such as you sent are more than welcome
  • Small cosmetic changes are OK in case they don't change the appearance of the elements at OmaStadi in any way. It's been built particularly for that instance and we are aware it's not fully interoperable with the Decidim default layout
  • Feature changes such as Adding author's name(s) on idea page and card #11 may be more difficult and I think the way you propose is the best. Suggest it and we'll look at it.

Currently it may take a while to get a response from us especially for something that needs more time to review since we're still working on the upcoming phases. Sorry for that inconvenience.

@PierreMesure
Copy link
Contributor Author

No worries, I don't mind using a fork for things that might not be merged quickly. Thanks for clarifying regarding the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants