You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey,
After some users reported (Clon1998/mobileraker_companion#82) that my companion still issues notifications while the plugin records a frame, I debugged my code and was able to locate the issue.
The root cause is the GCode macro TIMELAPSE_TAKE_FRAME. To be more precise, the timing when it updates the is_paused variable. Basically, at the moment, the GCode sets the is_paused variable to false before the printer actually reports that it's back in the printing state. This causes my companion to still be in the paused state while the is_paused is already set to false resulting in a new notification.
On my end, I updated my code to include a workaround that internally resets the variable only after the printer actually reports that it changed its state back to printing.
The text was updated successfully, but these errors were encountered:
Hey,
After some users reported (Clon1998/mobileraker_companion#82) that my companion still issues notifications while the plugin records a frame, I debugged my code and was able to locate the issue.
The root cause is the GCode macro
TIMELAPSE_TAKE_FRAME.
To be more precise, the timing when it updates theis_paused
variable. Basically, at the moment, the GCode sets theis_paused
variable to false before the printer actually reports that it's back in theprinting
state. This causes my companion to still be in thepaused
state while theis_paused
is already set to false resulting in a new notification.On my end, I updated my code to include a workaround that internally resets the variable only after the printer actually reports that it changed its state back to
printing
.The text was updated successfully, but these errors were encountered: