Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Amount in ERC-20 transfers interpreted as CSPR currency #743

Open
ghost opened this issue Jul 25, 2023 · 0 comments
Open

[BUG] Amount in ERC-20 transfers interpreted as CSPR currency #743

ghost opened this issue Jul 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 25, 2023

TL;DR

For contract's argument named amount value is always interpreted as CSRP - this is really confusing for ERC-20 calls.

Problem description

I got asked why calling ERC-20's transfer is displaying wrong amount:

image

So I located that part in UI, and it appears DeployValue is using isKeyOfCurrencyValue() to determine if CSPR price is used:

image

image

I think argument should not be interpreted basing solely on its name.

Required information

  • Casper Wallet Version: 1.4.1
@ghost ghost added the bug Something isn't working label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants