Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CRC of telemetry messages #9

Merged
merged 4 commits into from
May 26, 2020
Merged

Check CRC of telemetry messages #9

merged 4 commits into from
May 26, 2020

Conversation

dsferruzza
Copy link
Member

@dsferruzza dsferruzza commented May 22, 2020 •
edited
Loading

Telemetry messages in themselves are untouched but need to be wrapped this way:

  1. Arbitrary header: 0x03, 0x0C (2 bytes)
  2. Message
  3. CRC32 (IEEE) digest of the message (4 bytes)
  4. Arbitrary footer: 0x30, 0xC0 (2 bytes)

hbs
hbs reviewed May 22, 2020
View reviewed changes
Copy link
Collaborator

@hbs hbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide valid frames so testing compatibility of CRC implementation is easier in other languages

@dsferruzza
Copy link
Member Author

@hbs I updated:

  • the description of this PR to indicate exactly what changed ⬆
  • the records/few_fake_cycles_with_errors file to provide a small example of the new telemetry frames

@dsferruzza dsferruzza marked this pull request as ready for review May 24, 2020 15:21
@dsferruzza dsferruzza merged commit d712586 into master May 26, 2020
@dsferruzza dsferruzza deleted the add-crc branch May 26, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbs hbs hbs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsferruzza @hbs