chore: address nit

maliroteh-sf · May 30, 2024 · 279fff7 · 279fff7
1 parent 9ee713d
commit 279fff7
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/test/unit/common/CommonUtils.test.ts b/test/unit/common/CommonUtils.test.ts
@@ -363,16 +363,15 @@ describe('CommonUtils', () => {
     }
 
     async function verifyDownloadFails(url: string, mockResponse: any) {
+        const fake = (options: any, callback: (res: http.IncomingMessage) => void) => {
+            setTimeout(() => callback(mockResponse), 100);
+            return { on: () => {}, end: () => {} };
+        };
+
         if (url.startsWith('https:')) {
-            httpsGetStub.callsFake((_, callback) => {
-                setTimeout(() => callback(mockResponse), 100);
-                return { on: () => {}, end: () => {} };
-            });
+            httpsGetStub.callsFake(fake);
         } else {
-            httpGetStub.callsFake((_, callback) => {
-                setTimeout(() => callback(mockResponse), 100);
-                return { on: () => {}, end: () => {} };
-            });
+            httpGetStub.callsFake(fake);
         }
 
         try {