Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BLE ad data generation method #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shreyasminocha
Copy link

@shreyasminocha shreyasminocha commented Feb 21, 2025

Resolves #100

Note

Please consider squashing and replacing the commit message.

@malmeloo
Copy link
Owner

I appreciate the effort, but I'm not sure if this is the right approach to implementing it. The library already contains code to extract the public key from broadcast data (see the scanner code), and it would probably make sense to implement the reverse operation in the library as well. A method in the HasPublicKey class would probably suffice.

@shreyasminocha shreyasminocha changed the title Add BLE data generation example Add BLE ad data generation method Feb 25, 2025
@malmeloo
Copy link
Owner

Looks good, but now the example is missing 😄. Do you want to add it or should I merge and add it myself?

@shreyasminocha
Copy link
Author

Ah, I misunderstood your last comment. I can add the example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example to generate broadcast data
2 participants