-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos in type definition #88
Comments
It might also be a good chance to add a note on whether the list of possible values for |
update got reverted somehow. will fix and, yes, we should state that "type" list is not exclusive. with a fallback for when client's don't recognize the value of "type" |
Should we remove the sentence about |
removing would be OK w/ me. AFAIK, the word's definition does not call for exhastiveness. but happy to improve clarity here. |
As we're following concepts of HTML pretty closely I had assumed it was a reference to the concept of an enumerated attribute like this: https://stackoverflow.com/questions/4104110/what-are-enumerated-attributes-in-html |
that's a very reasonable assumption. i agree that we should drop "enumerated". it's a small change for a big win. |
As per the discussion in mamund/hal-forms#88, the list of property types in HAL FORMS is not exhaustive. This means we cannot align them with HTML input types and even more so not drop anything not an HTML input type. This is now implemented by switching to generic Strings in the HAL FORMS property DTO and directly piping the value originally registered on the affordance into it.
As per the discussion in mamund/hal-forms#88, the list of property types in HAL FORMS is not exhaustive. This means we cannot align them with HTML input types and even more so not drop anything not an HTML input type. This is now implemented by switching to generic Strings in the HAL FORMS property DTO and directly piping the value originally registered on the affordance into it.
https://rwcbook.github.io/hal-forms/#_code_type_code
"Possible settings for the type value adn teh expected contents to be returned inthe are:"
Should be?:
"Possible settings for the type value and the expected contents to be returned in here are:"
The text was updated successfully, but these errors were encountered: