Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkglib_testing requires pkglib.six #40

Open
eeaston opened this issue Mar 28, 2014 · 4 comments
Open

pkglib_testing requires pkglib.six #40

eeaston opened this issue Mar 28, 2014 · 4 comments

Comments

@eeaston
Copy link
Contributor

eeaston commented Mar 28, 2014

My reason for creating pkglib_util was to create a non-pkglib-enabled place to put common code that's used in both pkglib and pkglib_testing. This is so pkglib_testing can be installed as a standalone package without pkglib, something some users have mentioned is desirable. The recent import of six into pkglib has reintroduced that dependency.

We can fix this by either
a) move pkglib.six into pkglib_util.six, or
b) re-declare six as an install dependency of pkglib_testing.

I'm re-organising pkglib_testing at the moment and going down the 'b' route at the moment, but can easily change. Whaddaya reckon?

@Wilfred
Copy link
Collaborator

Wilfred commented Mar 28, 2014

Ah, sorry about that.

I'd prefer 'a'. We have some internal code that's pinned at six==1.3.0, and some code that's pinned at six==1.4.1. It'd make my life much easier if we include a copy of six.

Otherwise, if pkglib depends on (say) six>=1.5, it would be impossible to use pkglib with packages that depend on older versions of six. That would be a shame.

@eeaston
Copy link
Contributor Author

eeaston commented Mar 28, 2014

Coolio, I'll move it into pkglib_util. Commit-o-doom incoming

@Wilfred
Copy link
Collaborator

Wilfred commented Apr 2, 2014

Interestingly, pip also includes a copy of the libraries it depends on: https://github.com/pypa/pip/tree/develop/pip/_vendor

@eeaston
Copy link
Contributor Author

eeaston commented Apr 2, 2014

Gosh. And I thought we were being semi-bad with just the one - they have loads in there! Good spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants