Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check public headers conform to c++ ISO standards #1184

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

64
Copy link
Member

@64 64 commented Nov 3, 2024

Previously only C ISO versions were checked. Check C++ versions too.

@64 64 force-pushed the cpp-pedantic branch 4 times, most recently from b19eb98 to 83c886d Compare November 3, 2024 03:26
@64 64 marked this pull request as ready for review November 3, 2024 03:26
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments, this LGTM.

@64 64 force-pushed the cpp-pedantic branch 6 times, most recently from 7455c21 to 716df53 Compare November 8, 2024 02:29
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@64 64 added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@64 64 force-pushed the cpp-pedantic branch 4 times, most recently from 4263556 to e1ff36a Compare November 29, 2024 01:57
@64 64 enabled auto-merge November 29, 2024 22:58
@64 64 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into managarm:master with commit 7299994 Nov 29, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants