-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download history management and other improvements #59
base: main
Are you sure you want to change the base?
Conversation
Very good job 👍 Suggestion : Add in the "logs" list the pending ones. Else we don't know what is in the pending queue ; and other reason : if the service is stopped, I feel that we loose all our pendings :'( |
I did it in https://github.com/gallofeliz/youtube-dl-server ;) |
Looks great @gallofeliz, refactoring a bit and adding resume on start, I'll merge with my fork later today. Cheers! |
Merged, @gallofeliz, and resuming the pendings on start now. Thanks again! |
Yes, it will be a great app :) I don't know Python so refactoring after me is good ahah ! Regards |
Hi, I issue slow UI sometimes, I don't know why. Regards |
Hi @gallofeliz do you have more details about the slowness you are seeing? Any specific actions that make it slow? |
Hi @nbr23, I removed the comment about interrupted running job because I didn't reproduce it. For me the job was ended because youtube-dl said it in the cli logs but maybe it needs a lot of time to finish the encoding or to write to the disk. About the slow, I will see. |
@gallofeliz ok weird, I have not seen any slownesses so far. I will keep an eye out. I've updated the logs page a little to just show the color on the status and not the whole line. That should make it easier on the eye ;) |
Yes good. I will stop to develop for the moment and begin to use :) The next step for me is to be able to stop it correctly ... When I do CTRL-C, it doesn't stop. I need to do it 3 times. I don't know how to do, I tried exit(0) but without success. Regards |
Is this still work in progress? any chance for merge? |
@fluential it is stable and can be merged |
@manbearwiz can this be merged? |
f675f3c
to
2282c57
Compare
?? |
This is super dope... I've got the fork pulled and running great on my unRAID box. It'd be AMAZING to see this merged and given an official Community Apps release! 😁🤩 |
6964170
to
04ff741
Compare
This is the best youtube downloader I've seen by far. Longing for the newer version with file size showing for finished download. |
That is correct yes! |
4403bdd
to
3591a98
Compare
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.2 to 4.24.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.2...v4.24.0) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Hello,
Adding a few features and updating the UI slightly while trying to remain in the original spirit:
Update 23/04/2020:
Update 25/04/2020:
Update 10/05/2020:
Update 10/06/2020:
Cheers!