Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not uninstall Python libraries #1154

Open
Ana06 opened this issue Oct 29, 2024 · 0 comments
Open

Do not uninstall Python libraries #1154

Ana06 opened this issue Oct 29, 2024 · 0 comments
Labels
❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Oct 29, 2024

Details

packages/libraries.python3.vm/tools/chocolateyuninstall.ps1 can uninstall libraries installed before the installation of libraries.python3.vm if any of the libraries was already installed. We do not uninstall Python libraries installed by other packages such as flare-capa installed by ida.plugin.capa.vm. I think this is a confusing behavior and as uninstalling is best effort I suggest to remove the file and not uninstall any previously installed Python library. This simplifies the code to maintain and removes the confusion.

In addition, we should remove the VM-Pip-Uninstall function that is not used.
@Ana06 Ana06 added the ❔ discussion Further discussion is needed label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❔ discussion Further discussion is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ana06