Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go strings integration tasks #826

Closed
3 tasks done
Tracked by #841
mr-tz opened this issue Jul 12, 2023 · 9 comments
Closed
3 tasks done
Tracked by #841

Go strings integration tasks #826

mr-tz opened this issue Jul 12, 2023 · 9 comments
Assignees

Comments

@mr-tz
Copy link
Collaborator

mr-tz commented Jul 12, 2023

Tasks

Preview Give feedback

image 1
2023-07-12_12-24-33_WindowsTerminal

image 2
2023-07-12_11-29-15_WinMergeU

@mr-tz
Copy link
Collaborator Author

mr-tz commented Jul 12, 2023

For task 2 and 3 I think the console setting (width) results in the added new lines...

@Arker123
Copy link
Collaborator

For task 2 and 3 I think the console setting (width) results in the added new lines...

So, to address this, should I increase the width setting?

@williballenthin
Copy link
Collaborator

if the case is what @mr-tz mentioned, then its rich deciding to wrap the string across multiple lines, based on the current width of the terminal. we should decide what the behavior should be. i think two reasonable options include:

  • don't wrap, and truncate strings at the end of the terminal, though this potentially makes it difficult to review the complete string contents
  • don't wrap, and let the terminal wrap long lines, as strings.exe does. i dont think blindly changing the console width is the right fix here, since i can trivially construct a string that's longer than whatever width you pick. instead, we should read more about rich and how to change the behavior.

@Arker123
Copy link
Collaborator

render \t vs. tab (strings.exe does the latter)

Is this feature already in place?

image

@Arker123
Copy link
Collaborator

Go build ID string split into multiple lines, see image1?

Could we utilize the enrich library for this task?

Enriched extends [rich](https://pypi.org/project/rich/) library functionality with a set of changes that were not accepted to rich itself.

Reference:- https://github.com/pycontribs/enrich

@mr-tz
Copy link
Collaborator Author

mr-tz commented Aug 21, 2023

render \t vs. tab (strings.exe does the latter)

Is this feature already in place?

image

we need to decide which behavior we want and make sure it's consistent across the output functions

is that the case currently?

@Arker123
Copy link
Collaborator

is that the case currently?

Yes, that is currently the case.

@mr-tz
Copy link
Collaborator Author

mr-tz commented Aug 21, 2023

Ok, then we only have the wrapping issue left to fix.

@mr-tz
Copy link
Collaborator Author

mr-tz commented Aug 21, 2023

closed via #861

@mr-tz mr-tz closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants