CONTRIBUTING.md

Welcome 💖

Before anything else, thank you for taking some of your precious time to help this project move forward. ❤️

If you're new to open source and feeling a bit nervous 😳, we understand! We recommend watching this excellent guide to give you a grounding in some of the basic concepts. We want you to feel safe to make mistakes, and ask questions.

If anything in this guide or anywhere else in the codebase doesn't make sense to you, please let us know! It's through your feedback that we can make this codebase more welcoming, so we'll be glad to hear thoughts.

You can chat with us in the #committers-js channel in our Community Slack, or feel free to raise an issue if you're experiencing any friction trying make your contribution.

Local setup

To get a local development environment:

• use Git to fork and clone the repo
• If you're running Windows, make sure to enable Developer Mode
• install Node.Js
• Make sure you have a recent version of npm installed: npm install -g npm
• npm install - Install dependencies
• npm test - Compile typescript and run the tests

If everything passes, you're ready to hack! ⛏

Tests

Type npm run or see the package.json scripts section for how to run each category of tests.

• lint - npm run lint
  • prettier
  • eslint
  • dependency-lint
• typescript tests - npm run types-test
  • tsd
• unit tests - npm run unit-test
  • mocha
  • chai
  • sinon
• compatibility kit - npm run cck-test
  • checking that cucumber-js emits the correct messages
• feature tests - npm run feature-test
  • cucumber-js tests itself

API Documentation

The functionality exposed under the @cucumber/cucumber/api entry point is analysed and has documentation generated by API Extractor. If you make a change that affects the public API surface, you'll need to run npm run docs:local to run the analysis and regenerate the docs, and commit the changes. If you forget to do this locally, the CI build will fail and remind you.

Internals

Project Structure

└── src
    │
    ├── api                   # main runCucumber function etc
    │
    ├── cli                   # executing from argv
    │
    ├── configuration         # loading, merging, validating configuration
    │
    ├── formatter             # displaying the results
    │
    ├── models                # data structures
    │
    ├── runtime               # run test cases, emits the event protocol
    │
    └── support_code_library  # load hooks / step definitions

The runtime emits events with an EventEmitter

Coding style

• Promises and ES7 async/await
• Try to make things as unit testable as possible. If it's hard to unit test, the class/function may be doing too much.

Changelog

• Every PR should have a changelog entry
• The contributor should update the changelog
• Each entry in the changelog should include a link to the relevant issues/PRs