Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract metrics.jar from collections-advisor-agent uber jar in runtime #8

Open
manoelcampos opened this issue Oct 20, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@manoelcampos
Copy link
Owner

That will avoid having to place the metrics jar into some dir where the app is being executed.
That metrics.jar is load in the bootstrap class load because it's shared between the agent and the app.
This way, it enables the agent to store static data and the app to read it.

By requiring the sample jar to be into the app/agent dir so that the agent can load it on the bootstrap classloader, makes it more difficult to use the agent.
Since the agent is a uber jar that have the metrics as a dependency in the pom.xml, we can extract the metrics.jar dynamically from the uber jar and load it on the bootstrap class path.

For more details check #5.

@manoelcampos manoelcampos self-assigned this Oct 20, 2021
@manoelcampos manoelcampos added the enhancement New feature or request label Oct 20, 2021
@manoelcampos manoelcampos changed the title Extract metrics.jar from collections-advisor-agent uber jar Extract metrics.jar from collections-advisor-agent uber jar in runtime Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant