Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom prompts location change #43

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Custom prompts location change #43

merged 2 commits into from
Jul 10, 2024

Conversation

falquaddoomi
Copy link
Collaborator

This PR does the following:

  • editor.py: adds config_dir as a second, optional argument to ManuscriptEditor
  • editor.py: modifies ManuscriptPromptConfig to take config_dir instead of config_dir
  • replaces ai_revision-*.yaml with ai-revision-*.yaml across the codebase
  • updates tests with new filenames and new config location

Various PRs in this and other repos will depend on this change, specifically:

…Config to take config_dir and look for its configuration there. Renames ai_revision- to ai-revision- to avoid confusion w/hyphens vs. underscores. (NOTE: the next commit will include all the file renames, since there are a lot; tests are broken in this commit)
@falquaddoomi falquaddoomi merged commit 0df3568 into manubot:main Jul 10, 2024
@falquaddoomi falquaddoomi deleted the custom-prompts-location-change branch July 10, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants