-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deemphasize portions of the route line that the user has passed #1307
Comments
This is happening in mapbox/mapbox-gl-native#12575. 🎉 |
This is blocked by the fact that data-driven properties don’t support transitions: mapbox/mapbox-gl-js#3170. So even once the map SDK supports line gradients, we’d have to constantly change the |
Also blocked by mapbox/mapbox-gl-native#12917, which appears to be much more straightforward to fix than the other blocker, mapbox/mapbox-gl-js#3170. |
No longer blocked by mapbox/mapbox-gl-native#12917. Still blocked by mapbox/mapbox-gl-js#3170. |
@1ec5 Can you please double check the milestone. I accidently put this on 1.1 milestone. I think it is v0.x next. |
No, it’s correctly slated for v1.1.0. |
@1ec5 is mapbox/mapbox-gl-js#3170 still considered a requirement to complete this feature? |
Yes, a port of mapbox/mapbox-gl-js#3170 to gl-native would be required for considering the feature complete, so that the route line would begin at the puck instead of steadily fading in around the puck. However, it doesn’t block initial work to implement the feature. That PR doesn’t change anything in the style specification, so my assumption is that hard stops entail adding duplicate stops with the same line distance value. The problem with that on iOS is that |
#2377 implemented the bulk of the requested feature. We’re tracking some tail work:
|
Portions of the route line that the user has already passed should be displayed in a more muted or translucent color, to better emphasize the portion that the user still has yet to reach. This effect would be most prominent in overview mode, but even in straight-ahead mode, the line would look different above and below the user puck.
Contrary to the initial explorations in #1162, we’ll keep the line’s geometry constant as the user moves. However, we’ll change the line gradient (
MGLLineStyleLayer.lineGradient
) to abruptly go from translucent to opaque at the user’s location along the line, with a smooth transition (lineGradientTransition
) that matches the puck’s animated interpolation. Line gradients will be implemented in the map SDK for mapbox/mapbox-gl-native#11718./cc @mapbox/navigation-ios @danesfeder
The text was updated successfully, but these errors were encountered: