Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form component should have a disabled prop, which disables submission even with the Enter key #102

Open
davidtheclark opened this issue Jan 2, 2020 · 0 comments
Labels
bug Something isn't working jira-sync-complete

Comments

@davidtheclark
Copy link
Contributor

We recently had a bug where we disabled the FormSubmit component (using its disabled prop), but the Form could still be submitted with the Enter key. To avoid this situation, there should be a disabled prop on the Form component, which we could have set to true.

(In the meantime, the workaround is to do nothing in the handleFormData callback when the form should be disabled.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira-sync-complete
Projects
None yet
Development

No branches or pull requests

2 participants