-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving the map with active navigation leads to marker getting dragged off the route #27
Comments
With the update to MapLibre native 6.0.0 there is an issue where puck.mp4 |
@boldtrn Do you see this as a maplibre-navigation issue or should we consider opening an issue at MapLibre Native? Currently this is a blocker for using the latest version. |
I think this issue existed before the Maplibre Update as well, but maybe it was not so frequent?
Good question, I guess this depends on if we expect this call to actually happen during the animation. My feeling is that this callback should be called and if it is not called, this is probably an issue with Maplibre itself, but I am not 100% sure. Have you tried it Maplibre 6.3? If it still occurs with 6.3 maybe you could bring this up either as issue or discussion in the Slack? |
The bug was especially noticeable when panning quickly or zooming in while navigating. The issue is that the upstream method signature changed in 76469a0c2227927f03a15fb95b3a20f34becc78c and then again in 8ad5f9c1fd58c60b93d26c2819637fd8f2144fd1 So our "overridden method" wasn't actually being called. It's not the commit authors fault that it broke - this is a private method we're calling. A longer term fix might be to include some kind of public stable delegate method rather than an override.
The bug was especially noticeable when panning quickly or zooming in while navigating. The issue is that the upstream method signature changed in 76469a0c2227927f03a15fb95b3a20f34becc78c and then again in 8ad5f9c1fd58c60b93d26c2819637fd8f2144fd1 So our "overridden method" wasn't actually being called. It's not the commit authors fault that it broke - this is a private method we're calling. A longer term fix might be to include some kind of public stable delegate method rather than an override.
The bug was especially noticeable when panning quickly or zooming in while navigating. The issue is that the upstream method signature changed in 76469a0c2227927f03a15fb95b3a20f34becc78c and then again in 8ad5f9c1fd58c60b93d26c2819637fd8f2144fd1, which first appeared in the ios-v6.0.0 tag. So our "overridden method" wasn't actually being called. It's not the commit authors fault that it broke - this is a private method we're calling. A longer term fix might be to include some kind of public stable delegate method rather than an override.
The bug was especially noticeable when panning quickly or zooming in while navigating. The issue is that the upstream method signature changed in 76469a0c2227927f03a15fb95b3a20f34becc78c and then again in 8ad5f9c1fd58c60b93d26c2819637fd8f2144fd1, which first appeared in the ios-v6.0.0 tag. So our "overridden method" wasn't actually being called. It's not the commit authors fault that it broke - this is a private method we're calling. A longer term fix might be to include some kind of public stable delegate method rather than an override.
Steps to Trigger Behavior
Expected Behavior
The marker should stay on the location of the user
Actual Behavior
It is moved away
Version(s) affected
The text was updated successfully, but these errors were encountered: