From 39f1672e309067799762c8b9b1020ae0c949ee30 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Mon, 1 Jul 2024 14:25:22 -0700 Subject: [PATCH 1/3] Add "Build Example Project" to CI --- .github/workflows/ios.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index dff8c5df..8ca7ce21 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -39,4 +39,7 @@ jobs: run: set -o pipefail && xcodebuild build -scheme maplibre-navigation-ios -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' | xcbeautify --renderer github-actions - name: Test - run: set -o pipefail && xcodebuild test -scheme maplibre-navigation-ios -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' | xcbeautify --renderer github-actions \ No newline at end of file + run: set -o pipefail && xcodebuild test -scheme maplibre-navigation-ios -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' | xcbeautify --renderer github-actions + + - name: Build Example Project + run: set -o pipefail && xcodebuild build -project Example/Example.xcodeproj -scheme Example -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" | xcbeautify --renderer github-actions From 1f585b13b0adc8b8024289c903fb0c5526378e87 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Mon, 1 Jul 2024 14:36:55 -0700 Subject: [PATCH 2/3] avoid pinning to specific simulator version. its breaks as the available platforms change on CI --- .github/workflows/ios.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index 8ca7ce21..93006dac 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -36,10 +36,10 @@ jobs: uses: actions/checkout@v4 - name: Build - run: set -o pipefail && xcodebuild build -scheme maplibre-navigation-ios -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' | xcbeautify --renderer github-actions + run: set -o pipefail && xcodebuild build -scheme maplibre-navigation-ios -destination 'generic/platform=iOS' | xcbeautify --renderer github-actions - name: Test run: set -o pipefail && xcodebuild test -scheme maplibre-navigation-ios -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' | xcbeautify --renderer github-actions - name: Build Example Project - run: set -o pipefail && xcodebuild build -project Example/Example.xcodeproj -scheme Example -destination 'platform=iOS Simulator,OS=17.0.1,name=iPhone 15 Pro' CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" | xcbeautify --renderer github-actions + run: set -o pipefail && xcodebuild build -project Example/Example.xcodeproj -scheme Example -destination 'generic/platform=iOS' CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" | xcbeautify --renderer github-actions From 243fa1a6ff642358032d978101682ee506a213f3 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Mon, 1 Jul 2024 15:35:18 -0700 Subject: [PATCH 3/3] fix Example app --- Example/example/SceneDelegate.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Example/example/SceneDelegate.swift b/Example/example/SceneDelegate.swift index 39603c5f..7cc88fab 100644 --- a/Example/example/SceneDelegate.swift +++ b/Example/example/SceneDelegate.swift @@ -94,7 +94,7 @@ private extension SceneDelegate { let simulatedLocationManager = SimulatedLocationManager(route: route) simulatedLocationManager.speedMultiplier = 2 - self.viewController.startNavigation(with: route, locationManager: simulatedLocationManager) + self.viewController.startNavigation(with: route, animated: true, locationManager: simulatedLocationManager) } }