Update deps, fix new sqlx usage #1428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+397
to
+400
| #[allow(clippy::cast_possible_truncation)] | ||
| let min_zoom = validate_zoom(info.min_zoom.map(|v| v as i32), "zoom_level")?; | ||
| #[allow(clippy::cast_possible_truncation)] | ||
| let max_zoom = validate_zoom(info.max_zoom.map(|v| v as i32), "zoom_level")?; |
There was a problem hiding this comment.
I don't think the truncation here is the best option.
fn validate_zoom does check if the value can be casted to u8 via u8::try_from
Changing to fn validate_zoom(zoom: Option<i64>, zoom_name: &'static str) -> MbtResult<Option<u8>> seems like a better option
Suggested change
| #[allow(clippy::cast_possible_truncation)] | |
| let min_zoom = validate_zoom(info.min_zoom.map(|v| v as i32), "zoom_level")?; | |
| #[allow(clippy::cast_possible_truncation)] | |
| let max_zoom = validate_zoom(info.max_zoom.map(|v| v as i32), "zoom_level")?; | |
| let min_zoom = validate_zoom(info.min_zoom, "zoom_level")?; | |
| let max_zoom = validate_zoom(info.max_zoom, "zoom_level")?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1475