You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Martin should be able to create these with de-duplicated names, e.g. function_dup.1, function_dup.2, etc.
Implementation notes
The complex part is that configuration must be able to support multiple argument types. Config spec may need to be expanded, and we would need to support function argument parsing. Parsing should also do some basic PostgeSQL type normalization like int -> int4 and bigint -> int8
postgres:
functions:
function_source_id:
schema: "public"# Idea 1: more ergonomic, but harder to implement:function: "function_zxy_query(int4, int4, int4)"# Idea 2: less ergonomic but simplerfunction: function_zxy_queryargs: ["int4", "int4", "int4"]
fn query_available_function(...) -> InfoMap<InfoMap<(PgSqlInfo, FunctionInfo)>>, which is a HashMap<String, HashMap<String, (PgSqlInfo, FunctionInfo)>> - in other words a map of schema name to a map of function name (unique) to all the data about the given function. In order to support multiple names, it would have to be changed to something like this: InfoMap<InfoMap<HashMap<Vec<String>, (PgSqlInfo, FunctionInfo)>>> (list of arguments is used as a key to arguments).
The text was updated successfully, but these errors were encountered:
PR #543 adds a few more unit tests:
Martin should be able to create these with de-duplicated names, e.g.
function_dup.1
,function_dup.2
, etc.Implementation notes
int -> int4
andbigint -> int8
fn query_available_function(...) -> InfoMap<InfoMap<(PgSqlInfo, FunctionInfo)>>
, which is aHashMap<String, HashMap<String, (PgSqlInfo, FunctionInfo)>>
- in other words a map of schema name to a map of function name (unique) to all the data about the given function. In order to support multiple names, it would have to be changed to something like this:InfoMap<InfoMap<HashMap<Vec<String>, (PgSqlInfo, FunctionInfo)>>>
(list of arguments is used as a key to arguments).The text was updated successfully, but these errors were encountered: