Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): update thiserror to v2 #1581

Merged
merged 2 commits into from
Dec 11, 2024
Merged

chore(tests): update thiserror to v2 #1581

merged 2 commits into from
Dec 11, 2024

Conversation

CommanderStorm
Copy link
Collaborator

This mainly follows https://github.com/dtolnay/thiserror/releases/tag/2.0.0 and should be fairly straightforeward

@CommanderStorm CommanderStorm changed the title update thiserror to v2 chore(tests): update thiserror to v2 Nov 15, 2024
@CommanderStorm CommanderStorm enabled auto-merge (squash) November 27, 2024 21:11
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs rebasing

@CommanderStorm CommanderStorm merged commit 9331f1c into main Dec 11, 2024
6 of 14 checks passed
@CommanderStorm CommanderStorm deleted the update-thiserror branch December 11, 2024 00:19
@CommanderStorm
Copy link
Collaborator Author

CommanderStorm commented Dec 11, 2024

WTF??
How did this automerge with CI not aggreeing on how I merged this..

(we don't have required checks => reasonable for github, was still unexpected)

CommanderStorm added a commit that referenced this pull request Dec 13, 2024
Sorry for this PR.
During merging
#1581, I
made a mistake in githubs UI and the lockfile did not get updated
properly.

This rectifies the issue. Sorry for the additional effort required 😓
This PR also reverts
#1599 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants