Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse() & read_*() issues #572

Open
4 tasks
joeflack4 opened this issue Feb 27, 2025 · 3 comments
Open
4 tasks

parse() & read_*() issues #572

joeflack4 opened this issue Feb 27, 2025 · 3 comments

Comments

@joeflack4
Copy link
Collaborator

joeflack4 commented Feb 27, 2025

Sub-issues

  • Read method: It might also be cool to have a .read_csv() method like pandas instead of the parse() function (Suggestion: MappingSetDataFrame: .to_csv() and read_csv() #517).
  • Disambiguation: There could also be better disambiguation between parse() and parse_file(), which do different things, but you can't tell by the function names.
  • Metadata lost: The parse() function simply reads and returns a pandas.DataFrame, not a sssom.MappingSetDataFrame.
  • Docs: read_csv() and read_pandas() are missing from the Python docs.
    • Edit: They are actually deprecated, but I don't know why.
@matentzn matentzn transferred this issue from mapping-commons/sssom Feb 28, 2025
@matentzn
Copy link
Collaborator

Partial duplicate: #517

@matentzn
Copy link
Collaborator

I am not opposed to redesign MSDF to look more like pandas.DataFrame overall. I will admit though that this is very low down the list of priorities right now.

I don't remember the point of the parse method, I would always use read_* methods..

@joeflack4
Copy link
Collaborator Author

joeflack4 commented Feb 28, 2025

@matentzn Thanks. Those methods are also not listed in the Python API documentation. I basically had to dig through the codebase until I found a function that worked.

I'll update the issue OP & title to be related to the read_* ones as well.

Edit: read_csv() and read_pandas() are actually deprecated, but I don't know why.

@joeflack4 joeflack4 changed the title parse() issues parse() & read_*() issues Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants