Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate, more intuitive representation of duplicate bubble boundary nodes #206

Open
3 of 4 tasks
fedarko opened this issue Feb 19, 2021 · 0 comments · May be fixed by #244
Open
3 of 4 tasks

Alternate, more intuitive representation of duplicate bubble boundary nodes #206

fedarko opened this issue Feb 19, 2021 · 0 comments · May be fixed by #244
Labels
hierarchical decomposition it took me a year to implement this so it had better be useful .___. highpriorityfeature

Comments

@fedarko
Copy link
Member

fedarko commented Feb 19, 2021

Idea from Mihai: change the shapes -- so rather than showing two pentagons, one node is a triangle and the other one is a square (so it's still two nodes, but it looks like one node split up).

There are two cases to consider here:

  1. This node is oriented fwd: set the "first" duplicate to a square/rectangle □ and the second one to a triangle facing right ▷
  2. The node is oriented rev: set the "first" duplicate to a triangle facing left ◁ and the second one to a square/rectangle □

Another, related thing: I think we should adjust these nodes' sizes so that each of the duplicates has the area / dimensions of a node with exactly half of its length. This makes sense intuitively, although it might be annoying to rework the python code to make this happen.

Anyway, from here, everything is the same (and now we don't need to worry about that garish shade of pink) (garish is a good word).

If we eventually get to the point of using different node shapes (e.g. arrows -- see #211) then we can adjust the different shapes used here accordingly.

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hierarchical decomposition it took me a year to implement this so it had better be useful .___. highpriorityfeature
Projects
None yet
1 participant