Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yslow + PhantomJS against twitter.com fails #149

Open
Andrei- opened this issue Mar 29, 2015 · 4 comments
Open

Yslow + PhantomJS against twitter.com fails #149

Andrei- opened this issue Mar 29, 2015 · 4 comments

Comments

@Andrei-
Copy link

Andrei- commented Mar 29, 2015

Just tried PhantomJS with yslow script against twitter. Doesn't seem to work.
I tried two version of phantomjs, 1.8 and 2.0.
With 1.8 I get "Failed to load undefined"
With 2.0 I get "TypeError: undefined is not an object (evaluating args.length)

yslow_error_
@Andrei-
Copy link
Author

Andrei- commented Mar 29, 2015

Same against yahoo.com. Am I doing something wrong?

@Andrei-
Copy link
Author

Andrei- commented Mar 31, 2015

Mistery solved:
1.8 was failing because it was missing --ssl-protocol=any
2.0 was failing because .args in phantomjs.args has been removed (and probably previous reason as well)

@TeaEra
Copy link

TeaEra commented Dec 7, 2015

What should I do if I still want yslow to work under 2.0?

@soulgalore
Copy link
Contributor

You can locally merge this:
#150

@13rac1 13rac1 mentioned this issue Jan 2, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soulgalore @TeaEra @Andrei-