Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The MSD value returned by the function calc_grain_size is incorrect when plot='lin' is chosen #13

Closed
marcoalopez opened this issue Apr 15, 2019 · 1 comment
Closed

The MSD value returned by the function calc_grain_size is incorrect when plot='lin' is chosen #13

marcoalopez opened this issue Apr 15, 2019 · 1 comment
Assignees
@marcoalopez
Labels
bug

Comments

@marcoalopez
Copy link
Owner

line 143 in tools.py is

gsd = np.std(np.log(diameters))  # multiplicative (geometric) standard deviation

and should be

gsd = np.exp(np.std(np.log(diameters)))
@marcoalopez marcoalopez self-assigned this Apr 15, 2019
@marcoalopez marcoalopez changed the title the MSD value returned by the function "calc_grain_size" is incorrect when plot='lin' is chosen the MSD value returned by the functioncalc_grain_size is incorrect when plot='lin' is chosen Apr 15, 2019
@marcoalopez marcoalopez changed the title the MSD value returned by the functioncalc_grain_size is incorrect when plot='lin' is chosen the MSD value returned by the function calc_grain_size is incorrect when plot='lin' is chosen Apr 15, 2019
@marcoalopez marcoalopez changed the title the MSD value returned by the function calc_grain_size is incorrect when plot='lin' is chosen The MSD value returned by the function calc_grain_size is incorrect when plot='lin' is chosen Apr 15, 2019
@marcoalopez
Copy link
Owner Author

marcoalopez commented Apr 22, 2019 •
edited
Loading

This is fixed in the v2.0.3 of the script to be released in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoalopez marcoalopez

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcoalopez