Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Generic Functions in lib.php #10

Open
eduardokraus opened this issue Oct 24, 2024 · 2 comments
Open

Rename Generic Functions in lib.php #10

eduardokraus opened this issue Oct 24, 2024 · 2 comments

Comments

@eduardokraus
Copy link

eduardokraus commented Oct 24, 2024

There are some functions in lib.php with very generic names that may cause conflicts with other plugins. For example, the functions "row_fill" and "get_table_data".

Captura de Tela 2024-10-24 às 12 35 47

@marcusgreen
Copy link
Owner

I agree, and so I am working on a refactor to use a class called driprelease, which means I am converting existing references to a class called driprelease to be named dripdata, which is a better name.
The branch is here, and I will merge into main once I am happy it all works. I am currently getting a behat failure.

@marcusgreen
Copy link
Owner

I have now completed the refactoring and merged into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants