first 8 rows in the table have large line-height

[taylorchu]

[taylorchu]

tui-go/table_test.go

Line 36 in be6863e

││ │ ││....││

I wonder if this is intended.

[marcusolsson]

It is a consequence of the layout algorithm used in tui-go (which is the same as in the Qt project). Widgets in a Box fight for the space, and unless one of the widgets have the Expanding size policy, they will share the space equally. In a graphical application (with Qt) this isn't as big of an issue since pixels are smaller units of space.

The solution is probably to make the top or bottom widget expand:

widget.SetSizePolicy(tui.Preferred, tui.Expanding)

... or, to add a Spacer widget.

Let me know if it works for you!

[taylorchu]

I added a bottom spacer widget to the vbox that has the table. Strangely this does not shrink the table height. And setting size policy also does not work too.

[marcusolsson]

That should work though, so it might be a bug after all :) Do you think you could post an example with the problem? Thanks!

[taylorchu]

Here is a minimum example. It turns out that I have a no-break space in my text 🍰 .

package main

import (
	tui "github.com/marcusolsson/tui-go"
)

func main() {
	table := tui.NewTable(0, 0)
	for i := 0; i < 3; i++ {
		table.AppendRow(
			tui.NewLabel("test\u00a0test"),
		)
	}

	container := tui.NewVBox(table, tui.NewSpacer())
	container.SetBorder(true)
	container.SetSizePolicy(tui.Expanding, tui.Expanding)

	ui := tui.New(container)
	ui.SetKeybinding("Esc", func() { ui.Quit() })
	ui.Run()
}

[marcusolsson]

Confirming this as a bug. The spacer should claim the extra space from the table rows.