This repository has been archived by the owner on May 31, 2024. It is now read-only.
fix cli test #12
Merged
fix cli test #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@ml-evs This one is a PR-to-your-PR, feel free to merge when you have time. |
ml-evs
approved these changes
Nov 9, 2023
| py_cmd = "import subprocess; return subprocess.check_output(f'{command}', shell=True)" | ||
| command = [str(self.venv_dir / "bin" / "python"), "-c", py_cmd] | ||
| print(f"Executing {command=} in venv") | ||
| py_cmd = f"import subprocess; subprocess.check_output(r'{command}', shell=True)" |
There was a problem hiding this comment.
Suggested change
| py_cmd = f"import subprocess; subprocess.check_output(r'{command}', shell=True)" | |
| py_cmd = f"import subprocess; subprocess.check_output(r'{command}', shell=True)" |
Haha thanks, I wrote this as my Eurostar started boarding and then wasted the entire journey just re-running the tests without making any changes and scratching my head...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the API on my windows machine, also fixes CLI-with-venv test.