Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lein-midje not working with high-level Leiningen tasks (in plugin projects) #47

Open
xsc opened this issue Nov 2, 2013 · 13 comments
Open
Labels

Comments

@xsc
Copy link
Contributor

xsc commented Nov 2, 2013

Let's say I have the following in my project.clj:

...
  :eval-in :leiningen
  :profiles {:midje {:dependencies [[midje "1.5.1"]]
                     :plugins [[lein-midje "3.1.3-RC2"]]}}
...

No tests are defined so far, so midje should not encounter any failures. I call:

$ lein with-profile midje midje
Performing task 'midje' with profile(s): 'midje'
No facts were checked. Is that what you wanted?
Error encountered performing task 'midje' with profile(s): 'midje'
Suppressed exit

Exit code is 1, things like TravisCI will fail. Note that this works fine for non-:eval-in-leiningen projects, the fact that leiningen.core.main/exit is called even if no failure is encountered just breaks testing of, e.g., plugin projects in that manner.

@vbauer
Copy link

vbauer commented Nov 2, 2014

I'm not sure that this is a right place... but I have a similar and strange behavior:

vbauer@vladislav-bauer:~/workspace/clojure/lein-plantuml$ lein with-profile dev midje
All checks (10) succeeded.
Error encountered performing task 'midje' with profile(s): 'dev'
Suppressed exit

All tests passed, but I see "Error encountered performing task 'midje' with profile(s): 'dev'".
Any ideas?

PS: Yes, I have ":eval-in-leiningen true" in my project.clj

@xsc
Copy link
Contributor Author

xsc commented Nov 3, 2014

This change is the cause. @marick introduced it because on some platforms the plugin took several seconds to shut down after all tests have been run.

So I've been running [lein-midje "3.1.1"] in my plugin projects for a year now since the most recent versions are broken for that purpose.

vbauer added a commit to vbauer/lein-plantuml that referenced this issue Nov 4, 2014
lein-midje has bug marick/lein-midje#47 which prevents to run tests correctly on Travis CI
@vbauer
Copy link

vbauer commented Nov 5, 2014

@xsc Thank you for the hint! I've downgraded lein-midje to the version 3.1.1 and it works pretty fine on Travis CI.

Will it be fixed in future versions of the plugin?

@xsc
Copy link
Contributor Author

xsc commented Nov 5, 2014

Well, this issue has been open for a year and three days now, so I'm not overly confident, the maintainers really see this as something that needs fixing...

@mahnunchik
Copy link

+1

3 similar comments
@xvik
Copy link

xvik commented Nov 5, 2014

+1

@atroxaper
Copy link

+1

@kirill-lakhtin
Copy link

+1

rasoliveira added a commit to rasoliveira/gnugo-gtp that referenced this issue Nov 22, 2014
Travis CI does not work reporting that 'midje' is not a lein task.

- Downgrading it to version 3.1.1 should now fix the problem (marick/lein-midje#47)
@marick
Copy link
Owner

marick commented Nov 29, 2014

I've now put this on the trello board. The problem with fixing it is that understanding how Leiningen behaves has gotten a lot more difficult than it used to be.

@marick
Copy link
Owner

marick commented Nov 29, 2014

@cypt
Copy link

cypt commented Jan 29, 2015

+1

@vbauer
Copy link

vbauer commented Jan 29, 2017

Any news about this problem?..

@marick
Copy link
Owner

marick commented Feb 17, 2017

Sorry for the delayed reply. I've moved from Clojure on the backend to Elixir. Because of that, I can't devote time to lein-midje. I will do what I can to transition it to anyone who wants to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants