Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe viewer's column chart are aggregated on the backend #3104

Open
mscolnick opened this issue Dec 10, 2024 · 0 comments
Open

Dataframe viewer's column chart are aggregated on the backend #3104

mscolnick opened this issue Dec 10, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
marimo 1.0.0

Comments

@mscolnick
Copy link
Contributor

mscolnick commented Dec 10, 2024 •
edited
Loading

Description

Currently we send up to 20k rows of data to the frontend to aggregate columns summaries. This aggregation happens in vega-lite and can cause memory issues and slowdowns.

Suggested solution

We would like to:

  1. move this aggregation to the backend. either using vega-fusion (if installed) or narwhals.Expr.hist (if/when implemented)
  2. lazily make these requests based on content visibility on the frontend

Alternative

No response

Additional context

This could help: narwhals-dev/narwhals#1561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
marimo 1.0.0
Development

No branches or pull requests
1 participant
@mscolnick