Also deprecate SINK_NICKNAME, and small fixes

Author: marioortizmanero

README.md

@@ -92,8 +92,8 @@ Options:
   --node-type <node_type>
         Whether to consider PulseAudio sinks (output) or sources (input).
         All the operations of pulseaudio-control will apply to one of the two.
-        Pass `input` for the sources, e.g. a microphone
-        Pass `output` for the sinks, e.g. speakers, headphones
+        Pass `input` for the sources, e.g. a microphone.
+        Pass `output` for the sinks, e.g. speakers, headphones.
         Default: "output"
   --volume-max <int>
         Maximum volume to which to allow increasing.
@@ -109,7 +109,7 @@ Options:
   --node-nicknames-from <prop>
         pactl property to use for node names, unless overriden by
         --node-nickname. Its possible values are listed under the 'Properties'
-        key in the output of `pactl list sinks` and `pactl list sources`
+        key in the output of `pactl list sinks` and `pactl list sources`.
         Default: none
   --node-nickname <name>:<nick>
         Nickname to assign to given node name, taking priority over
@@ -189,14 +189,14 @@ scroll-down = pulseaudio-control --node-type input --volume-max 130 down
 
 ## Useful icons
 
-Here's a list with some icons from different fonts you can copy-paste. Most have an space afterwards so that the module has a bit of spacing. They may appear bugged on your browser if the font isn't available there. Please add yours if they aren't in the list.
+Here's a list with some icons from different fonts you can copy-paste. Most have a space afterwards so that the module has a bit of spacing. They may appear bugged on your browser if the font isn't available there. Please add yours if they aren't in the list.
 
-| Font name                                       | Volumes         | Muted            | Output icons               | Input icons   |
-| ----------------------------------------------- | :-------------: | :--------------: | :------------------------: | :-----------: |
-| [FontAwesome](https://fontawesome.com)          | `" , "`       | `" "` or `" "`  | `" "` or `" "`           | `", "`      |
-| [Material](https://material.io/resources/icons) | `" , , "`    | `" "` or `"󰍭 "` | `" "` or `" "` or `" "` | `"󰍬, 󰍮"`      |
-| Emoji                                           | `"🔈 ,🔉 ,🔊 "` | `"🔇 "`          | `"🔈 "` or `"🎧 "`         | `"🎙️ "`        |
-| Emoji v2                                        | `"🕨 ,🕩 ,🕪 "`    | `"🔇 "`          | `"🕨 "` or `"🎧 "`          | `"🎤 "`       |
+| Font name                                       | Volumes         | Muted            | Output icons               | Input icons |
+| ----------------------------------------------- | :-------------: | :--------------: | :------------------------: | :---------: |
+| [FontAwesome](https://fontawesome.com)          | `" , "`       | `" "` or `" "` | `" "` or `" "`           | `", "`    |
+| [Material](https://material.io/resources/icons) | `" , , "`    | `" "` or `"󰍭 "` | `" "` or `" "` or `" "` | `"󰍬, 󰍮"`    |
+| Emoji                                           | `"🔈 ,🔉 ,🔊 "` | `"🔇 "`          | `"🔈 "` or `"🎧 "`         | `"🎙️ "`      |
+| Emoji v2                                        | `"🕨 ,🕩 ,🕪 "`    | `"🔇 "`          | `"🕨 "` or `"🎧 "`          | `"🎤 "`     |
 
 Most of these can be used after downloading a [Nerd Font](https://www.nerdfonts.com/) and including it in your [Polybar config](https://github.com/polybar/polybar/wiki/Fonts). For example:
 

pulseaudio-control.bash

@@ -9,6 +9,7 @@
 # be displayed for users using it in custom FORMAT
 # shellcheck disable=SC2034
 ICON_SINK="Replaced by ICON_NODE, see https://github.com/marioortizmanero/polybar-pulseaudio-control/releases/tag/v3.0.0"
+SINK_NICKNAME="Replaced by NODE_NICKNAME, see https://github.com/marioortizmanero/polybar-pulseaudio-control/releases/tag/v3.0.0"
 
 # Defaults for configurable values, expected to be set by command-line arguments
 AUTOSYNC="no"
@@ -29,13 +30,16 @@ declare -a NODE_BLACKLIST
 
 # Special variable: within the script, pactl, grep, and awk commands are used
 # on sinks or sources, depending on NODE_TYPE.
+#
 # The commands are almost always the same, except for the sink/source part.
 # In order to reduce duplication, this variable is used for commands that behave
 # the same, regardless of the NODE_TYPE.
+#
 # Having only the "radix" (ink/ource) and omitting the first letter enables us
-# to use that single variable.
-# S-ink  , s-ink  , s-ink  -s, S-ink -s
-# S-ource, s-ource, s-ource-s, S-ource-s
+# to use that single variable:
+#
+#   S-ink  , s-ink  , s-ink  -s, S-ink -s
+#   S-ource, s-ource, s-ource-s, S-ource-s
 SINK_OR_SOURCE="ink"
 
 # Environment & global constants for the script
@@ -432,8 +436,8 @@ Options:
   --node-type <node_type>
         Whether to consider PulseAudio sinks (output) or sources (input).
         All the operations of pulseaudio-control will apply to one of the two.
-        Pass \`input\` for the sources, e.g. a microphone
-        Pass \`output\` for the sinks, e.g. speakers, headphones
+        Pass \`input\` for the sources, e.g. a microphone.
+        Pass \`output\` for the sinks, e.g. speakers, headphones.
         Default: \"$NODE_TYPE\"
   --volume-max <int>
         Maximum volume to which to allow increasing.
@@ -449,7 +453,7 @@ Options:
   --node-nicknames-from <prop>
         pactl property to use for node names, unless overriden by
         --node-nickname. Its possible values are listed under the 'Properties'
-        key in the output of \`pactl list sinks\` and \`pactl list sources\`
+        key in the output of \`pactl list sinks\` and \`pactl list sources\`.
         Default: none
   --node-nickname <name>:<nick>
         Nickname to assign to given node name, taking priority over