Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug: screener.Screener dropping first row on each page #132

Open
amichael7 opened this issue May 20, 2022 · 2 comments
Open

Possible bug: screener.Screener dropping first row on each page #132

amichael7 opened this issue May 20, 2022 · 2 comments

Comments

@amichael7
Copy link

When running the finviz distribution from pypi, I noticed that the first row of screener results appears to be dropped. Before jumping in with a pull request, wanted to check if anyone else was having this issue.

I think I have spotted the potential issue, at line 30 of helper_functions/scraper_functions.py the enumerate call should start at 0 if you look at the finviz page source.

if rows != -2:
    for row_number, row_data in enumerate(all_rows, 1):
        data_sets.append(dict(zip(headers, row_data)))
        if row_number == rows:  # If we have reached the required end
            break

If anyone else is having this issue, I'll put in the pull request.

@marcodiri
Copy link

This has already been addressed #128
Probably Pypi is not updated yet.

@RiverRo
Copy link

RiverRo commented Oct 6, 2022

My cloned copy works fine but the pypi version still omits the first rows. when will pypi be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants