Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis issues #27

Open
ghost opened this issue Nov 4, 2020 · 2 comments
Open

Static analysis issues #27

ghost opened this issue Nov 4, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 4, 2020


Issue 1:
https://github.com/mariusbancila/stduuid/blob/master/include/uuid.h#L801

Up cast and hashing of null bytes in almost every use case except when dealing with compiler specific types


Issue 2:
https://github.com/mariusbancila/stduuid/blob/master/include/uuid.h#L734

Improper assumption of word alignment = alignment of byte


Issue 3:
https://github.com/mariusbancila/stduuid/blob/master/include/uuid.h#L729
https://github.com/mariusbancila/stduuid/blob/master/include/uuid.h#L761

Missing namespace base uuid


@mariusbancila
Copy link
Owner

Pinpointing on the actual code would be better as the source code is evolving and the lines no longer match.

@mariusbancila mariusbancila changed the title - Static analysis issues Dec 22, 2021
@NovaSmoof
Copy link
Contributor

I think this post is referring to commit: da98fcf. My reasoning for this guess is that this commit (and the one previous to it that is nearly identical for the sake of these issues) is the only one in 2020 that has a templated string function on line 801 that performs hashing. And that the word/byte alignment problem's function starts on line 734. But I have absolutely no clue what the missing namespace base uuid means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants