Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce and streamline CSS #5

Open
markahesketh opened this issue Jun 18, 2012 · 2 comments
Open

Reduce and streamline CSS #5

markahesketh opened this issue Jun 18, 2012 · 2 comments

Comments

@markahesketh
Copy link
Owner

  • Cut out all CSS specific to the default theme.
  • Reduce CSS to bare minimum needed for each page
  • Keep page-specific CSS seperate and included with setMedia(), to be concatenated reducing file size.
  • Consider object-orientated CSS (http://oocss.org/) to make style changes when developing a new theme very fast.
  • Reduce need for so many classes by styling elements instead
@damonsk
Copy link
Contributor

damonsk commented Nov 28, 2012

I'm currently using this boilerplate as a base and creating a style upon it, I've noticed there is no defined CSS/Less for the shopping-cart html. If I was to create a base style/css structure, would it be suitable to place this within the global.less file. Since prestashop doesn't include a separate css file for the shopping-cart, this seems like the only logical location without users having to call addCSS.

Whats your view on this?

@markahesketh
Copy link
Owner Author

If there's no shopping-cart.css thats automatically included then it'd depend on what I was making.

If I was making a generic theme to sell etc I'd put it in global as you suggest, however if I was working on a client store where I had control over the overrides etc I'd use addCSS/setMedia to include the CSS on the shopping-cart only.

I'm going to be reevaluating the theme over the next couple of days, upgrading it to 1.5.2, and reconsidering using LESS etc and stripping everything back to become more of a boilerplate, and less of a Framework so all kinds of assumptions are removed.

Mark Hesketh
07874035593
http://www.markhesketh.co.uk

On Wednesday, 28 November 2012 at 09:43, Damon Skelhorn wrote:

I'm currently using this boilerplate as a base and creating a style upon it, I've noticed there is no defined CSS/Less for the shopping-cart html. If I was to create a base style/css structure, would it be suitable to place this within the global.less file. Since prestashop doesn't include a separate css file for the shopping-cart, this seems like the only logical location without users having to call addCSS.
Whats your view on this?


Reply to this email directly or view it on GitHub (#5 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants