Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice job, idea for improvement #3

Open
tits4net opened this issue Mar 8, 2024 · 1 comment
Open

Nice job, idea for improvement #3

tits4net opened this issue Mar 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tits4net
Copy link

tits4net commented Mar 8, 2024

Hey !

I found this repo a few days ago and it's a very nice job, thanks a lot !

Your map idea was perfect for me but the containerization and CI was still something WIP ... so I took a few hour to create my own "wrapper" around your repo fork if you want to have a look : https://github.com/tits4net/motomap.

I would be ready to do a PR for part of it if you want, let me know !

As I now have a working repo with all the basics I may work on following topics, if I can give back to this repo ;-)

  • Adding elevation data
  • Investigate --bound option for mkgmap
  • Fix a few build warning
  • Find a easy and clean way to add / remove POI type on the map
  • Add a flag to add / remove the dirt roads/tracks hack
@markcushman
Copy link
Owner

Hey thanks for the feedback! I did this mainly for myself but glad you found it useful!

I was doing this to automate building the pre-built maps for https://motomap.org/ and since I host the files on Azure I wanted to make it all run there. Basic workflow is:

  1. Whenever I update the motomap styles or mkgmap config, build a new container image and store it in an Azure Container Registry
  2. Have an Azure Function download the source maps from Geofabrik and push them to storage, create the .yaml configs beside them (this is WIP)
  3. I have an Azure Function that listens for uploaded files: https://github.com/markcushman/motomap_mapupload and then launches an ACI from the registry to build the map and output the .img file back to storage
  4. Alert gets sent to me that a new map was created (LogAnalytics Alert rule)
  5. Links on https://motomap.org/ get updated to the new location

Your updates to add/remove POI and dirt roads/tracks could be flags in the .yaml config file - I wanted to be able to use that config file in the future for more options. Idea is to have a "map builder" website where you could go "order" a map to be built, give it the options you want - this generates the .yaml and then my automated Azure process would build the map and e-mail the user once complete with a download location.

For the maps themselves I do want to do a few things:

  • Need a way for several maps to coexist on the Zumo and have seamless borders - right now if the map is over 2Gb (I think) then the Zumo won't recognize it. You can load multiple maps to the Zumo but the "seams" suck.
  • Still trying to optimize the file size of these maps, I did reduce complexity by removing building outlines and parking lot aisles, still more to do here though.

If you make improvements to the map code to make the maps better I'll for sure take PRs, and if your wrapper can coexist with my build process for Azure I'm totally open for that as well.

@markcushman markcushman added the enhancement New feature or request label Mar 8, 2024
@markcushman markcushman self-assigned this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants