Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundMVPAnnouncement not fired #584

Open
maruo34 opened this issue Mar 10, 2025 · 0 comments
Open

RoundMVPAnnouncement not fired #584

maruo34 opened this issue Mar 10, 2025 · 0 comments

Comments

@maruo34
Copy link

maruo34 commented Mar 10, 2025

Describe the bug
RoundMVPAnnouncement not fired never

To Reproduce
Download link to an affected demo: faceit

Code:

	parser.RegisterEventHandler(func(e events.RoundMVPAnnouncement) {
		defer func() {
			if r := recover(); r != nil {
				log.Printf("Panic RoundMVPAnnouncement event: %v", r)
			}
		}()

		log.Printf("MVP: %s", e.Player.Name)

		if player := e.Player; player != nil {
			stats := getOrCreatePlayerStats(playerStats, player.SteamID64)
			stats.mvps++
		}
	})

Expected behavior
I found another way to get mpv, but it's strange why it doesn't work in this event

	parser.RegisterEventHandler(func(e events.FrameDone) {
		for _, pl := range parser.GameState().Participants().All() {
			stats := getOrCreatePlayerStats(playerStats, pl.SteamID64)
			stats.mvps = pl.MVPs()
			stats.rank = pl.Rank()
			stats.RankType = pl.RankType()
		}
	}

Library version
v4.3.3

also I don't quite understand this is either a problem of faceit or the library, most likely faceit. The number of kills and deaths of assists will not match in the summary of the faceit match. I noticed this when I played

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant