Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions on the episode length of 1000 on gfootball env instead of a maximum env limit of 400 #83

Open
DeeDive opened this issue Aug 22, 2023 · 1 comment

Comments

@DeeDive
Copy link
Contributor

DeeDive commented Aug 22, 2023

Dear authors,

Thank you for this work! Could you please address a question that confuses me? I notice that the gfootball env terminates at a maximum of 400 steps as stated in their paper. But I also notice that the training scripts of gfootball set an episode length of 1000. Can you explain your motivation on that? (football scripts e.g. see https://github.com/marlbenchmark/on-policy/blob/b21e0f743bd4516086825318452bb6927a33538d/onpolicy/scripts/train_football_scripts/train_football_ca_hard.sh#L14C16-L14C20)

Best!

@DeeDive
Copy link
Contributor Author

DeeDive commented Aug 22, 2023

I know that the vec env will automatically reset the env when it encounters the done=True flag. But I would appreciate it if you address my questions that

  1. how do we typically set this length value, and
  2. why do you set it here to more than two times the maximally allowed episode length?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant