Fixed bug in subs

marques-work · Jul 9, 2014 · 9b46129 · 9b46129
1 parent 7620b27
commit 9b46129
Show file tree

Hide file tree

Showing 12 changed files with 183 additions and 183 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "asteroid",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "homepage": "https://github.com/mondora/asteroid",
   "authors": [
     "Paolo Scanferla <[email protected]>"

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "asteroid",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Aletrnative Meteor client",
   "main": "dist/node.asteroid.js",
   "scripts": {

diff --git a/src/subscription.js b/src/subscription.js
@@ -20,6 +20,7 @@ Subscription.constructor = Subscription;
 
 Subscription.prototype.stop = function () {
 	this._asteroid.ddp.unsub(this.id);
+	delete this._asteroid._subscriptionsCache[this._hash];
 };
 
 Subscription.prototype._onReady = function () {
@@ -28,7 +29,6 @@ Subscription.prototype._onReady = function () {
 
 Subscription.prototype._onStop = function () {
 	delete this._asteroid.subscriptions[this.id];
-	delete this._asteroid._subscriptionsCache[this._hash];
 };
 
 Subscription.prototype._onError = function (err) {

diff --git a/test/coverage/Chrome 35.0.1916 (Mac OS X 10.9.3)/dist/asteroid.js.html b/test/coverage/Chrome 35.0.1916 (Mac OS X 10.9.3)/dist/asteroid.js.html
@@ -1246,11 +1246,11 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">1071</span>
+<span class="cline-any cline-yes">1305</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">1071</span>
-<span class="cline-any cline-yes">1071</span>
+<span class="cline-any cline-yes">1305</span>
+<span class="cline-any cline-yes">1305</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">9</span>
@@ -1259,10 +1259,10 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">1062</span>
+<span class="cline-any cline-yes">1296</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">1062</span>
+<span class="cline-any cline-yes">1296</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1287,8 +1287,8 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">314</span>
-<span class="cline-any cline-yes">314</span>
+<span class="cline-any cline-yes">332</span>
+<span class="cline-any cline-yes">332</span>
 <span class="cline-any cline-yes">4</span>
 <span class="cline-any cline-yes">4</span>
 <span class="cline-any cline-yes">4</span>
@@ -1308,11 +1308,11 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">45</span>
-<span class="cline-any cline-yes">45</span>
-<span class="cline-any cline-yes">360</span>
+<span class="cline-any cline-yes">63</span>
+<span class="cline-any cline-yes">63</span>
+<span class="cline-any cline-yes">504</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">45</span>
+<span class="cline-any cline-yes">63</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
@@ -1328,12 +1328,12 @@ <h2>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">767</span>
+<span class="cline-any cline-yes">821</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">466</span>
-<span class="cline-any cline-yes">466</span>
+<span class="cline-any cline-yes">502</span>
+<span class="cline-any cline-yes">502</span>
 <span class="cline-any cline-yes">7</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1346,8 +1346,8 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">301</span>
-<span class="cline-any cline-yes">301</span>
+<span class="cline-any cline-yes">319</span>
+<span class="cline-any cline-yes">319</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1575,11 +1575,11 @@ <h2>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1603,40 +1603,40 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">69</span>
+<span class="cline-any cline-yes">87</span>
 <span class="cline-any cline-yes">2</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">67</span>
+<span class="cline-any cline-yes">85</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">67</span>
+<span class="cline-any cline-yes">85</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
-<span class="cline-any cline-yes">67</span>
-<span class="cline-any cline-yes">67</span>
+<span class="cline-any cline-yes">85</span>
+<span class="cline-any cline-yes">85</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">67</span>
-<span class="cline-any cline-yes">67</span>
-<span class="cline-any cline-yes">47</span>
+<span class="cline-any cline-yes">85</span>
+<span class="cline-any cline-yes">85</span>
+<span class="cline-any cline-yes">65</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2</span>
 <span class="cline-any cline-yes">2</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">45</span>
+<span class="cline-any cline-yes">63</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">67</span>
+<span class="cline-any cline-yes">85</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">69</span>
-<span class="cline-any cline-yes">45</span>
+<span class="cline-any cline-yes">87</span>
+<span class="cline-any cline-yes">63</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">69</span>
+<span class="cline-any cline-yes">87</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -1814,31 +1814,31 @@ <h2>
 <span class="cline-any cline-yes">12</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">528</span>
+<span class="cline-any cline-yes">744</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">660</span>
-<span class="cline-any cline-yes">588</span>
-<span class="cline-any cline-yes">588</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">930</span>
+<span class="cline-any cline-yes">804</span>
+<span class="cline-any cline-yes">804</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">528</span>
-<span class="cline-any cline-yes">450</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">744</span>
+<span class="cline-any cline-yes">640</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">78</span>
+<span class="cline-any cline-yes">104</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -2092,13 +2092,13 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">302</span>
-<span class="cline-any cline-yes">301</span>
+<span class="cline-any cline-yes">320</span>
+<span class="cline-any cline-yes">319</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">300</span>
-<span class="cline-any cline-yes">300</span>
+<span class="cline-any cline-yes">318</span>
+<span class="cline-any cline-yes">318</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">300</span>
+<span class="cline-any cline-yes">318</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
@@ -2119,8 +2119,8 @@ <h2>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">72</span>
-<span class="cline-any cline-yes">71</span>
+<span class="cline-any cline-yes">90</span>
+<span class="cline-any cline-yes">89</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1</span>
@@ -2136,10 +2136,10 @@ <h2>
 <span class="cline-any cline-yes">14</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">728</span>
-<span class="cline-any cline-yes">728</span>
-<span class="cline-any cline-yes">728</span>
-<span class="cline-any cline-yes">178</span>
+<span class="cline-any cline-yes">944</span>
+<span class="cline-any cline-yes">944</span>
+<span class="cline-any cline-yes">944</span>
+<span class="cline-any cline-yes">204</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -2167,7 +2167,7 @@ <h2>
 <span class="cline-any cline-yes">15</span>
 <span class="cline-any cline-yes">15</span>
 <span class="cline-any cline-yes">15</span>
-<span class="cline-any cline-yes">229</span>
+<span class="cline-any cline-yes">255</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">15</span>
@@ -3275,7 +3275,7 @@ <h2>
 
 </div>
 <div class="footer">
-    <div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Jul 05 2014 22:48:08 GMT+0200 (CEST)</div>
+    <div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Jul 09 2014 11:17:00 GMT+0200 (CEST)</div>
 </div>
 
 <script src="../prettify.js"></script>

diff --git a/test/coverage/Chrome 35.0.1916 (Mac OS X 10.9.3)/dist/index.html b/test/coverage/Chrome 35.0.1916 (Mac OS X 10.9.3)/dist/index.html
@@ -249,7 +249,7 @@ <h2>
 </div>
 </div>
 <div class="footer">
-    <div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Jul 05 2014 22:48:08 GMT+0200 (CEST)</div>
+    <div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Jul 09 2014 11:17:00 GMT+0200 (CEST)</div>
 </div>
 
 <script src="../prettify.js"></script>

diff --git a/test/coverage/Chrome 35.0.1916 (Mac OS X 10.9.3)/index.html b/test/coverage/Chrome 35.0.1916 (Mac OS X 10.9.3)/index.html
@@ -249,7 +249,7 @@ <h2>
 </div>
 </div>
 <div class="footer">
-    <div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sat Jul 05 2014 22:48:08 GMT+0200 (CEST)</div>
+    <div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Wed Jul 09 2014 11:17:00 GMT+0200 (CEST)</div>
 </div>
 
 <script src="prettify.js"></script>