Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote via GitHub comment #42

Open
marshall7m opened this issue Nov 25, 2022 · 0 comments
Open

Vote via GitHub comment #42

marshall7m opened this issue Nov 25, 2022 · 0 comments
Labels
chatops This issue is relation to developing components for chat-driven workflows

Comments

@marshall7m
Copy link
Owner

marshall7m commented Nov 25, 2022

Allow the appropriate voters to approve/reject Terraform deployments via PR comments. Currently the only method to vote is via a comment until webhooks for reactions are supported (see discussion here). This should be the primary way voters can cast their vote since they could look at the PR changes and vote all within GitHub. This could be implemented by provisioning a separate GitHub webhook for PR comments that would kick off a Lambda Function that will:

  1. Check if the GitHub user is a valid voter for that AWS account (maybe send a GitHub comment saying they are an invalid voter if not)
  2. Update the vote count and send a Step Function success task token if the count is met
  3. Send a PR comment using a GitHub bot account that notifies the user that their vote has been submitted
@marshall7m marshall7m changed the title Approval Terraform plan via GitHub comment Vote via GitHub comment Nov 26, 2022
@marshall7m marshall7m added the chatops This issue is relation to developing components for chat-driven workflows label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chatops This issue is relation to developing components for chat-driven workflows
Projects
None yet
Development

No branches or pull requests

1 participant