Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More types #5

Merged
merged 4 commits into from
Dec 28, 2023
Merged

More types #5

merged 4 commits into from
Dec 28, 2023

Conversation

martinkozle
Copy link
Owner

  • Add missing sensor types, and more missing value types
  • Fix-up environment variables loading
  • Add more tests
    • Overall for all cities
    • Environment variable loading

@martinkozle martinkozle self-assigned this Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (74cd3c4) 95.13% compared to head (28cc548) 97.75%.

Files Patch % Lines
pulseeco/api/pulse_eco_api.py 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   95.13%   97.75%   +2.61%     
==========================================
  Files          11       11              
  Lines         288      356      +68     
  Branches       28       37       +9     
==========================================
+ Hits          274      348      +74     
+ Misses          6        4       -2     
+ Partials        8        4       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinkozle martinkozle merged commit 55e6946 into main Dec 28, 2023
9 checks passed
@martinkozle martinkozle deleted the more-types branch January 5, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant