Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar height not excluded from screen height in android #28

Open
Hinaser opened this issue May 13, 2019 · 2 comments
Open

Status bar height not excluded from screen height in android #28

Hinaser opened this issue May 13, 2019 · 2 comments

Comments

@Hinaser
Copy link

Hinaser commented May 13, 2019

Hi.
I found an issue in height calculation for android.
There is a known issue for android height definition.

Reference: https://qiita.com/uutarou10/items/1aad5fd2d03fb54e0dbf

For iOS, height of window and screen is the same.

But for android it isn't. See picture below.

So, for android, we must exclude statusbar height from screenHeight.

I'll soon send a PR to fix this issue.

@marudy
Copy link
Owner

marudy commented May 17, 2019

Thanks a lot for your contribution @Hinaser . Will have a look and we 'll proceed with that.

@Vaneste
Copy link

Vaneste commented Oct 29, 2020

Any news about that ?
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants