Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates invalid graphql for oneof types #5

Open
tmc opened this issue Sep 19, 2019 · 1 comment
Open

Generates invalid graphql for oneof types #5

tmc opened this issue Sep 19, 2019 · 1 comment

Comments

@tmc
Copy link

tmc commented Sep 19, 2019

message OneOf {
  message Value {
    oneof value {
      string string_value = 1;
      int64 int_value = 2;
    }
  }
}

generates

input OneOf {
}
@marwan-at-work
Copy link
Owner

@tmc does it work if you just do the following:

message Value {
    oneof value {
      string string_value = 1;
      int64 int_value = 2;
    }
}

I say this because this is potentially because Value is an embedded message for OneOf. I haven't explicitly added support for embedded types but I plan on doing so. I'm busy for the next month or so but happy to take PRs if you or anyone wants to give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants