Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release process #638

Open
rgoldberg opened this issue Nov 15, 2024 · 0 comments · May be fixed by #640
Open

Improve release process #638

rgoldberg opened this issue Nov 15, 2024 · 0 comments · May be fixed by #640
Assignees
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Milestone

Comments

@rgoldberg
Copy link
Contributor

A catchall issue for improving the release process.

@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Nov 15, 2024
@rgoldberg rgoldberg self-assigned this Nov 15, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
…sistent with the shebangs that are used throughout.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
…sion values.

It only seems to be used for testing with `act`. `event.json` should either be generated or be manually created; in either case, it should reside somewhere that is ignored by git, as the only source of version info in git should be version tags.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
…mmand substitutions, respectively.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Remove commented code.

Improve step name.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
…b instead of once per each step of that job.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Change YAML emoji to fix spacing issue.

Move YAML lint before Git lint to keep the names getting progressively shorter.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
We shouldn't need to delete `Brewfile.lock.json` because it doesn't actually lock anything; it just records versions that were installed.

If we don't delete it, new `brew bundle install` run just adds info about what was installed during its run to the existing info about previous bundle installs.

By not deleting, the code can be simplified as per this commit.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Remove mise.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
…same OS, then a checksum is required only for the oldest OS version that shares that bottle/checksum; all later versions of the OS will use that checksum.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Fix acceptable argument count.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Use braces around bash variable uses.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 16, 2024
Ensure no newlines at beginning of any file.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 22, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 22, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
… tag & current revision for local (i.e. non-release builds), since releases should all be for a version tagged revision.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
Remove useless `--strict` from `swiftlint` in `script/format`.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 23, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
… tag & current revision for local (i.e. non-release builds), since releases should all be for a version tagged revision.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
Remove useless `--strict` from `swiftlint` in `script/format`.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant