Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubies (#1) #39

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update rubies (#1) #39

wants to merge 13 commits into from

Conversation

maxirmx
Copy link

@maxirmx maxirmx commented Aug 4, 2022

  • Resolve gcc 11 compatibility issue (7z.so fails to compile with gcc 11.x #36)
    This issue happens when newer versions of gcc are used where default C++ standard is 17. There is an obvious mismatch in
    7z code
    if (!mftRec.Parse(ByteBuf, Header.SectorSizeLog, numSectorsInRec, NULL, 0)) instead of if (!mftRec.Parse(ByteBuf, Header.SectorSizeLog, numSectorsInRec, 0, NULL))
    Newer versions of 7z have this fix. I have made a backport.
  • Resolve Ruby 3.0.x/rubygems/bundler cache issue with 7z.so (p7zip converted to Ruby extension)
    The issue occurs with Ruby 3.0.x where 7z.so built outside of Ruby extension system was not considered for bundler cache
  • Update GHA to run with new Rubies
  • Use RSpec rake task

cc: @ronaldtse

This is a contribution from Metanorma (GitHub), a product of Ribose (GitHub).

* update GHA to run with multiple rubies
* feat: use RSpec rake task
* Resolve gcc 11 compatibility issue (masamitsu-murase#36)
* Resolve Ruby 3.0.x/bundler cache issue with 7z.so (p7zip converted to Ruby extension)

Co-authored-by: Maxim [maxirmx] Samsonov <[email protected]>
@maxirmx maxirmx marked this pull request as ready for review August 4, 2022 18:01
@ronaldtse
Copy link

ronaldtse commented Aug 5, 2022

(Thank you @maxirmx !)

@masamitsu-murase first of all, thank you for the fantastic gem! We (@riboseinc) have been using your seven_zip_ruby gem for our @metanorma and @fontist projects, and have a need to utilize the gem on the latest platforms and Ruby versions. I hope this PR of our contribution will be accepted. Thank you again!

@sergiopantoja
Copy link

This is a wonderful contribution! I was having the 7z.so issue as well and couldn't figure out the cause, but this branch solved it. Thank you.

@maxirmx maxirmx force-pushed the master branch 2 times, most recently from b6058f3 to 968e937 Compare August 15, 2022 18:14
maxirmx and others added 3 commits August 18, 2022 13:56
* Fix: Dll Loading

* Fix: Extract Path

* Update: p7zip 16.02

* Added a script to extract p7zip archive.

* Modified the program to support p7zip-16.02.

* Update: 7z1900 Dll's

* Patch: p7zip_16.02+dfsg-7.debian

* Modified p7zip/extract.sh to apply Debian Patch.

* Teeny version upgrade.

* Added Unit Test.

* Improved Unit Test.

* Added Unit Test.

* typo

* Added Unit Test.

* typo

* The code was improved.
Fixed an error message when decryption of wrong password failed.
Added taint marks to file paths in archives.

* Added the description of extrace.sh.

* Imported cut and pasted update of p7zip-16.02.
Besides, Added Tainted mark to generated Ruby String.

* The exception to be thrown was changed to an appropriate class.

* Merge completion

* Fixing issues

* Fixed invalid password tests

* rb_tainted_str_new (deprecated) --> rb_str_new

* Fixed merge issue

* Fixed compression level tests

* Consistent handling of invalid or missing passwords

Co-authored-by: niloufar <[email protected]>
maxirmx and others added 3 commits October 14, 2022 07:57
* Fixed GCC 12 compatibility
* Added tests on Alpine
* Added tests on Ruby 3.2
@bkmgit
Copy link

bkmgit commented Mar 12, 2024

@masamitsu-murase Any possibility of merging this or making the fork the official RubyGem version?

@maxirmx
Copy link
Author

maxirmx commented Mar 12, 2024

@masamitsu-murase Any possibility of merging this or making the fork the official RubyGem version?

@bkmgit

We have to publish a fork
It is there:
https://github.com/fontist/seven_zip_ruby
https://rubygems.org/gems/seven-zip

Thank you

@ronaldtse ronaldtse deleted the branch masamitsu-murase:master January 27, 2025 08:19
@ronaldtse ronaldtse deleted the master branch January 27, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants