Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be less cavalier about changing existing manufacturer IDs #59

Open
RikerW opened this issue Jan 21, 2025 · 0 comments
Open

Be less cavalier about changing existing manufacturer IDs #59

RikerW opened this issue Jan 21, 2025 · 0 comments

Comments

@RikerW
Copy link
Contributor

RikerW commented Jan 21, 2025

Since the editor determines how to display items by manufacturer, changing the ID of a new manufacturer silently vanishes anything that it had previously. This is the correct behavior re not displaying them, but changing the name should probably prompt a warning if you had previous items - since otherwise, they will be hidden from view but CC will still try to import them (possibly causing really cryptic errors, if the hidden items are malformed).

I'll try to work on this at some point, but this is being recorded as an issue anyway so I can remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant